feat: add disabled attribute handling to link #2101
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fixes #1620 <Link :disabled="disabled">
<!-- instead of -->
<Link :as="disabled ? 'button' : 'a'" :disabled="disabled"> |
Thanks for this! I think it's a good addition even though the Could you please implement it in the other packages as well? Thanks! |
pascalbaljet
added
the
needs more info/work
|
I'm closing this pull request due to lack of activity. If you're still working on this or have updates to share, feel free to open a new PR. We'd be happy to take another look. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds handling of the disabled attribute to links.
Problem:
Currently clicking on Links where the disabled attribute is set, triggers a request.
Solution:
Add a disabled prop to the Link Component and stop click & prefetch events, when attribute exists or is set to true
Notes:
The changes are currently only implemented in
@interia/vue.If accepted, I will implement it in
@interia/react&@interia/sveltetoo.